diff --git a/backend/src/main/java/pdl/backend/ImageController.java b/backend/src/main/java/pdl/backend/ImageController.java index a9ef950..8087761 100644 --- a/backend/src/main/java/pdl/backend/ImageController.java +++ b/backend/src/main/java/pdl/backend/ImageController.java @@ -65,16 +65,15 @@ public class ImageController { public ResponseEntity addImage(@RequestParam("file") MultipartFile file, RedirectAttributes redirectAttributes) { String contentType = file.getContentType(); - if (!contentType.equals(MediaType.IMAGE_JPEG.toString())) { + if (contentType != null && !contentType.equals(MediaType.IMAGE_JPEG.toString())) { return new ResponseEntity<>("Only JPEG file format supported", HttpStatus.UNSUPPORTED_MEDIA_TYPE); } - try { imageDao.create(new Image(file.getOriginalFilename(), file.getBytes())); } catch (IOException e) { return new ResponseEntity<>("Failure to read file", HttpStatus.NO_CONTENT); } - return new ResponseEntity<>("Image uploaded", HttpStatus.OK); + return new ResponseEntity<>("Image uploaded", HttpStatus.CREATED); } @GetMapping(value = "/images", produces = "application/json") diff --git a/backend/src/test/java/pdl/backend/ImageControllerTests.java b/backend/src/test/java/pdl/backend/ImageControllerTests.java index 13270b8..c9b2ed0 100644 --- a/backend/src/test/java/pdl/backend/ImageControllerTests.java +++ b/backend/src/test/java/pdl/backend/ImageControllerTests.java @@ -75,11 +75,11 @@ public class ImageControllerTests { @Test @Order(7) public void createImageShouldReturnSuccess() throws Exception { - final ClassPathResource imgFile = new ClassPathResource("test.jpg"); + final ClassPathResource imgFile = new ClassPathResource("images/test.jpg"); MockMultipartFile multipartFile = new MockMultipartFile("file", "test.jpg", "image/jpeg", imgFile.getInputStream()); this.mockMvc.perform(MockMvcRequestBuilders.multipart("/images").file(multipartFile)).andDo(print()) - .andExpect(status().isOk()); + .andExpect(status().isCreated()); } @Test