From 0f68a91c5de1d5bf10893f794630ca53d8a78804 Mon Sep 17 00:00:00 2001 From: Nessar Date: Thu, 16 Jul 2026 20:11:00 +0200 Subject: [PATCH] refactor: address loading review findings (#18) --- .../apartment-form/apartment-form.css | 11 - .../apartment-form/apartment-form.html | 7 +- .../apartment-form/apartment-form.spec.ts | 1 + .../apartment-list/apartment-list.ts | 2 +- .../apartments-page/apartments-page.html | 4 +- .../apartments-page/apartments-page.spec.ts | 5 +- .../apartments-page/apartments-page.ts | 4 +- .../components/lease-card/lease-card.spec.ts | 58 ++- .../app/components/lease-form/lease-form.css | 11 - .../app/components/lease-form/lease-form.html | 9 +- .../components/leases-page/leases-page.html | 4 +- .../leases-page/leases-page.spec.ts | 7 +- .../app/components/leases-page/leases-page.ts | 2 +- .../tenant-card/tenant-card.spec.ts | 17 + .../components/tenant-form/tenant-form.css | 11 - .../components/tenant-form/tenant-form.html | 7 +- .../components/tenants-page/tenants-page.html | 6 +- .../tenants-page/tenants-page.spec.ts | 3 +- .../components/tenants-page/tenants-page.ts | 4 +- .../src/app/services/file-download.service.ts | 49 ++ frontend/src/app/services/session.service.ts | 6 +- .../tenant-attachment-transfer.service.ts | 104 ++++ .../src/app/services/workspace-resource.ts | 114 +++++ .../app/services/workspace.service.spec.ts | 51 +- .../src/app/services/workspace.service.ts | 450 ++++++------------ frontend/src/styles.scss | 24 + 26 files changed, 607 insertions(+), 364 deletions(-) create mode 100644 frontend/src/app/services/file-download.service.ts create mode 100644 frontend/src/app/services/tenant-attachment-transfer.service.ts create mode 100644 frontend/src/app/services/workspace-resource.ts diff --git a/frontend/src/app/components/apartment-form/apartment-form.css b/frontend/src/app/components/apartment-form/apartment-form.css index 42d30cd..e42a8b5 100644 --- a/frontend/src/app/components/apartment-form/apartment-form.css +++ b/frontend/src/app/components/apartment-form/apartment-form.css @@ -27,17 +27,6 @@ background: var(--surface); box-shadow: 0 1px 0 rgba(255, 255, 255, 0.04); } -fieldset { - min-width: 0; - margin: 0; - padding: 0; - border: 0; -} -.primary-action mat-spinner { - display: inline-block; - margin-right: 8px; - vertical-align: middle; -} .form-grid { display: grid; grid-template-columns: minmax(0, 1fr); diff --git a/frontend/src/app/components/apartment-form/apartment-form.html b/frontend/src/app/components/apartment-form/apartment-form.html index 13a8847..7eba1d4 100644 --- a/frontend/src/app/components/apartment-form/apartment-form.html +++ b/frontend/src/app/components/apartment-form/apartment-form.html @@ -26,7 +26,10 @@ @if (error()) { } -
+

+ {{ saving() ? 'Enregistrement en cours.' : '' }} +

+
Nom de l'appartement