perf(planning): update plan observations incrementally
Cache an immutable occupancy per placements map and derive a candidate's time-off period groups, holiday-week completeness and placement tie key from its parent when one date is added or removed. The from-scratch computation stays as the test oracle and an opt-in shadow mode. A fast-check property test compares both after every operation. The loaded year drops from 66.5 s to 48.5 s and the protocol from 262.0 s to 193.7 s. Outcomes, explanations and final states stay identical. Refs #283 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
87d72064be
commit
7890a03a74
6 files changed
+717
-89
No files matched your search
@@ -45,3 +45,42 @@ final states compared with `a871f8f`.
|
||||
|
||||
The differences are within run-to-run noise. The functional suite passes
|
||||
666 tests across 34 files, including the frozen-engine check.
|
||||
|
||||
## #283: incremental plan observations
|
||||
|
||||
Each placements map now carries an immutable occupancy: its sorted placement
|
||||
dates, time-off period groups, public-holiday-week completeness and lazily
|
||||
computed calendar observations. A candidate derived from its parent by one added
|
||||
or removed date, or by a copy with the same dates, updates only the affected
|
||||
groups and holiday weeks. Unchanged groups keep their cached periods and
|
||||
observation objects. Maps built from snapshots, maps observed against another
|
||||
calendar and dates that are not in-horizon working days fall back to the
|
||||
from-scratch computation.
|
||||
|
||||
The from-scratch computation remains the oracle. A fast-check property test
|
||||
applies random add, remove and retype sequences across year boundaries, horizon
|
||||
edges, declared days, weekends and public holidays, and compares every step with
|
||||
it. An opt-in shadow mode (`VAC_OBSERVATION_SHADOW=1` or
|
||||
`setObservationShadowMode(true)`) compares both on every observation and throws
|
||||
on any mismatch. It passed across the frozen-engine check and all seven
|
||||
benchmark scenarios, whose outcomes, explanations and final states stay
|
||||
byte-identical.
|
||||
|
||||
| Measurement | Before | After |
|
||||
| ------------------- | --------: | --------: |
|
||||
| Vitest duration | 262.030 s | 193.680 s |
|
||||
| Loaded year | 66.497 s | 48.489 s |
|
||||
| Typed obligations | 4.964 s | 4.947 s |
|
||||
| Two years | 2.977 s | 1.906 s |
|
||||
| Three years | 10.049 s | 6.152 s |
|
||||
| Representative year | 0.569 s | 0.441 s |
|
||||
|
||||
A fresh loaded-year CPU profile of the bundled core took 46.8 seconds. Of the
|
||||
1.68 million observed placement maps, one was built from scratch; the rest were
|
||||
derived. Observations now take about 4 seconds. Candidate evaluation still
|
||||
dominates: 24.3 seconds in `evaluateRuleCandidate`, including 15.2 seconds of
|
||||
active objectives and 6.9 seconds of candidate finalization, plus 6.2 seconds
|
||||
assigning dates and about 5 seconds each of garbage collection and timer idle
|
||||
time.
|
||||
|
||||
The functional suite passes 669 tests across 35 files.
|
||||
Reference in new issue
Block a user