nessar/vac-optimizer
1
0 Fork 0
Code Issues 14 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

refactor(planning): consolidate plan observations in one module #282

New Issue
Closed
opened 2026-10-16 22:39:45 +02:00 by nessar · 1 comment
nessar commented 2026-10-16 22:39:45 +02:00
Owner
Copy link
Copy source

Parent

#279

What to build

Consolidate a plan's observations inside the planning core into one internal module: what the planning objectives see of a plan, namely time-off periods, work sequences, public-holiday weeks, leave-balance observations and the placement tie key. Candidate scoring, plan statistics and stable plan explanations read observations only through this module. This is a structure-only change: planning results and speed are unchanged. It is the prefactor that makes incremental observations a contained change.

Acceptance criteria

  • Every objective evaluation, tie-break, plan statistic and explanation that needs plan observations obtains them through the module. No other code computes them.
  • The core's public entry points and outcome and snapshot types are unchanged.
  • The frozen-engine differential check passes, and the seven benchmark scenarios produce identical complete outcomes, explanations and final states.
  • Benchmark timings are recorded before and after, showing no regression beyond run-to-run noise.
  • The functional coverage suite, type checks, lint and formatting pass.

Blocked by

## Parent #279 ## What to build Consolidate a plan's observations inside the planning core into one internal module: what the planning objectives see of a plan, namely time-off periods, work sequences, public-holiday weeks, leave-balance observations and the placement tie key. Candidate scoring, plan statistics and stable plan explanations read observations only through this module. This is a structure-only change: planning results and speed are unchanged. It is the prefactor that makes incremental observations a contained change. ## Acceptance criteria - [ ] Every objective evaluation, tie-break, plan statistic and explanation that needs plan observations obtains them through the module. No other code computes them. - [ ] The core's public entry points and outcome and snapshot types are unchanged. - [ ] The frozen-engine differential check passes, and the seven benchmark scenarios produce identical complete outcomes, explanations and final states. - [ ] Benchmark timings are recorded before and after, showing no regression beyond run-to-run noise. - [ ] The functional coverage suite, type checks, lint and formatting pass. ## Blocked by - #280
nessar added the ready-for-agent label 2026-10-16 22:39:45 +02:00
nessar added a new dependency 2026-10-16 22:39:46 +02:00
#283 perf(planning): update plan observations incrementally
nessar commented 2026-10-17 02:19:56 +02:00
Author
Owner
Copy link
Copy source

Done in PR #287 (87d7206): plan observations live in src/app/services/plan-observations.ts. Structure-only; all seven scenarios byte-identical, protocol 262.0 s before and after. Details: docs/benchmark/issue-279.md.

Done in PR #287 (87d7206): plan observations live in src/app/services/plan-observations.ts. Structure-only; all seven scenarios byte-identical, protocol 262.0 s before and after. Details: docs/benchmark/issue-279.md.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
dependencies
docker
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
javascript
needs-info
needs-triage
question
ready-for-agent
wontfix
No labels ready-for-agent
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
renovate (renovate) Bot nessar (nessar)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#283 perf(planning): update plan observations incrementally
nessar/vac-optimizer
Depends on
#280 test(planning): compare the engine against a frozen engine on random requests
nessar/vac-optimizer
Reference: nessar/vac-optimizer#282