refactor: address loading review findings (#18)

frontend/src/app/components/tenants-page/tenants-page.html

@@ -57,7 +57,7 @@
                 [attachmentError]="
                   tenant.id ? (workspace.tenantAttachmentErrors()[tenant.id] ?? '') : ''
                 "
-                [uploading]="workspace.uploadingTenantIds().has(tenant.id!)"
+                [uploading]="tenant.id ? workspace.uploadingTenantIds().has(tenant.id) : false"
                 [uploadProgress]="
                   tenant.id ? (workspace.tenantUploadProgress()[tenant.id] ?? null) : null
                 "
@@ -83,8 +83,8 @@
 } @else {
   <app-tenant-form
     [tenant]="editingTenant()"
-    [saving]="workspace.tenantSaving()"
-    [saveError]="workspace.tenantSaveError()"
+    [saving]="workspace.tenantSaving(editingTenant()?.id)"
+    [saveError]="workspace.tenantSaveError(editingTenant()?.id)"
     (cancelled)="closeForm()"
     (submitted)="saveTenant($event)"
   />

frontend/src/app/components/tenants-page/tenants-page.spec.ts

@@ -1,4 +1,3 @@
-import { signal } from '@angular/core';
 import { TestBed } from '@angular/core/testing';
 import { TenantsPage } from './tenants-page';
 import { WorkspaceService } from '../../services/workspace.service';
@@ -9,7 +8,7 @@ describe('TenantsPage', () => {
       providers: [
         {
           provide: WorkspaceService,
-          useValue: { loadTenants: () => undefined, tenantSaveError: signal('') },
+          useValue: { loadTenants: () => undefined, clearTenantSaveError: () => undefined },
         },
       ],
     }),

frontend/src/app/components/tenants-page/tenants-page.ts

@@ -23,12 +23,12 @@ export class TenantsPage {
   }
 
   openAddForm(): void {
-    this.workspace.tenantSaveError.set('');
+    this.workspace.clearTenantSaveError();
     this.editingTenant.set(null);
     this.showForm.set(true);
   }
   openEditForm(tenant: Tenant): void {
-    this.workspace.tenantSaveError.set('');
+    this.workspace.clearTenantSaveError(tenant.id);
     this.editingTenant.set(tenant);
     this.showForm.set(true);
   }